search

cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.
https://github.com/cmorten/opine/blob/main/.github/API/api.md
MIT License
854 stars 43 forks source link

[#110] Support Deno 1.9.0 #111

Closed asos-craigmorten closed 3 years ago

asos-craigmorten commented 3 years ago

Issue

Fixes #110

Details

Seems that something in 1.9.0 has regressed our ability to rely upon setPrototypeOf for constructing aspects of the response object. I have put in a patch, but probably worth exploring with the Deno community why this no longer works ( perhaps it wasn't meant to and a fix has gone into Deno, or it is meant to and something in 1.9.0 has introduced a bug into Deno? ).

CheckList

github-actions[bot] commented 3 years ago

Benchmark results

PR to merge feat/deno-1.9.0 a4d2756128d0e5fe4409824596c3effce9dc3d42 -> main ``` 1 middleware 7868.15 RPS 5 middleware 7340.47 RPS 10 middleware 7153.37 RPS 15 middleware 6939.61 RPS 20 middleware 6731.88 RPS 30 middleware 6129.15 RPS 50 middleware 5276.81 RPS 100 middleware 3874.20 RPS ```