cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.

https://github.com/cmorten/opine/blob/main/.github/API/api.md

MIT License

854 stars 43 forks source link

[NO-ISSUE] Fix compilation errors in the examples #122

Closed owenoclee closed 3 years ago

owenoclee commented 3 years ago

Issue

No issue.

Details

This PR updates some dependencies in the examples to fix compilation errors and also fixes a couple of readme typos.

I tested all of the examples so this should be exhaustive.

CheckList

[x] PR starts with [NO-ISSUE].
[x] Has been tested (where required).

cmorten commented 3 years ago

Oh wow, thanks for this @owenoclee !

I really should add some tests for these examples to prevent them getting out of date in future - will try find some time soon!

github-actions[bot] commented 3 years ago

Benchmark results

PR to merge fix-examples e5d3d4d92ad5997d582d2e76a74b7049f93b1dc7 -> main

``` 1 middleware 5649.80 RPS 5 middleware 5424.08 RPS 10 middleware 5266.84 RPS 15 middleware 5063.86 RPS 20 middleware 5026.27 RPS 30 middleware 4644.44 RPS 50 middleware 4152.66 RPS 100 middleware 3106.12 RPS ```

cmorten commented 3 years ago

Cool added some - cea7ac72e101684e91a7bd93cbfa02438434467c, e64340ffc3cf356a9adab777304001be4b47b703, e934cc37329a052abfd6ca6a23a7b96879c40519