cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.

https://github.com/cmorten/opine/blob/main/.github/API/api.md

MIT License

854 stars 43 forks source link

Cross-Platform Path Separatores in serveStatic #145

Closed cawoodm closed 2 years ago

cawoodm commented 3 years ago

Issue

Setup:

deno 1.14.3 (release, x86_64-pc-windows-msvc)
v8 9.4.146.19
typescript 4.4.2
Opine Version: 1.8.0

Details

The path separator \ for windows is inconsistently applied in serveStatic.ts and send.ts. In particular hasTrailingSlash() assumes / whereas the path which has been normalize() contains (and may end with) \.

cmorten commented 2 years ago

Hey @cawoodm 👋

I think I've released a fix for this, but could have missed somewhere! Would you be able to check if you still have the same issues with opine@2.0.2?