cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.
https://github.com/cmorten/opine/blob/main/.github/API/api.md
MIT License
854 stars 43 forks source link

fix: failing tests on windows #163

Closed cmorten closed 2 years ago

cmorten commented 2 years ago

Issue

No issue.

Details

Two tests are failing on windows:

This change looks to remedy the code / tests to get windows green on CI again.

CheckList

github-actions[bot] commented 2 years ago

Benchmark results

PR to merge fix/windows-test-failures 6015302633d0f98accf08a0fc377a1e41a35bee0 -> main ```console opine: 1 middleware ================================ 1 middleware Running 3s test @ http://localhost:3333/?foo[bar]=baz 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 2.29ms 676.25us 21.17ms 89.45% Req/Sec 2.19k 269.86 2.46k 85.00% Latency Distribution 50% 2.16ms 75% 2.41ms 90% 2.80ms 99% 4.07ms 13129 requests in 3.01s, 2.37MB read Requests/sec: 4360.48 Transfer/sec: 804.81KB opine: 10 middleware ================================ 10 middleware Running 3s test @ http://localhost:3333/?foo[bar]=baz 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 2.48ms 1.31ms 22.23ms 95.16% Req/Sec 2.10k 326.73 2.45k 82.26% Latency Distribution 50% 2.20ms 75% 2.41ms 90% 3.03ms 99% 8.18ms 12951 requests in 3.10s, 2.33MB read Requests/sec: 4172.75 Transfer/sec: 770.17KB opine: 50 middleware ================================ 50 middleware Running 3s test @ http://localhost:3333/?foo[bar]=baz 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 2.45ms 0.94ms 20.52ms 93.35% Req/Sec 2.07k 310.95 2.42k 79.03% Latency Distribution 50% 2.24ms 75% 2.58ms 90% 3.03ms 99% 6.00ms 12794 requests in 3.10s, 2.31MB read Requests/sec: 4120.73 Transfer/sec: 760.57KB std/http benchmark ================================ Server listening on localhost:3333 Running 3s test @ http://localhost:3333/?foo[bar]=baz 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 1.19ms 2.51ms 35.13ms 95.85% Req/Sec 6.35k 1.85k 9.18k 80.65% Latency Distribution 50% 641.00us 75% 0.86ms 90% 1.36ms 99% 14.30ms 39234 requests in 3.12s, 3.26MB read Requests/sec: 12579.43 Transfer/sec: 1.04MB deno_http_native benchmark ================================ Server listening on localhost:3333 Running 3s test @ http://localhost:3333/?foo[bar]=baz 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 0.86ms 1.31ms 22.28ms 96.77% Req/Sec 7.09k 1.33k 8.21k 87.10% Latency Distribution 50% 622.00us 75% 711.00us 90% 0.95ms 99% 7.46ms 43754 requests in 3.10s, 3.63MB read Requests/sec: 14113.10 Transfer/sec: 1.17MB ```