cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.
https://github.com/cmorten/opine/blob/main/.github/API/api.md
MIT License
854 stars 43 forks source link

[#22] Add res.redirect API #36

Closed FaberVitale closed 4 years ago

FaberVitale commented 4 years ago

References:

Issue

#22

Details

Implementation of the res.redirect api, resolves #22 .

References:

Notable changes comparared to expressJs version

Raises exception if arguments provided are not valid.

CheckList

github-actions[bot] commented 4 years ago

Benchmark results

PR to merge feat/issue-22-res-redirect-api 89a136b4047cf2c01ad0802f05e5024ab04f3fe7 -> main ``` 1 middleware 8137.14 RPS 5 middleware 8100.89 RPS 10 middleware 8063.51 RPS 15 middleware 8058.42 RPS 20 middleware 7666.85 RPS 30 middleware 7731.36 RPS 50 middleware 7382.41 RPS 100 middleware 6612.08 RPS ```
asos-craigmorten commented 4 years ago

One comment r.e. removing the superfluous content-length logic, otherwise looks amazing!

asos-craigmorten commented 4 years ago

Awesome job @FaberVitale! If you're keen can look to add you as a Contributor to the project?

Let's get this merged and released.