cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.
https://github.com/cmorten/opine/blob/main/.github/API/api.md
MIT License
854 stars 43 forks source link

[#42] Incorrect URL argument type #43

Closed srepollock closed 4 years ago

srepollock commented 4 years ago

Adding a new fix for issue #42. I have this project forked and used in my local branch.

This should be merged into master to address deno@1.2.0 users issues.

Version Info: deno 1.2.0 v8 8.5.216 typescript 3.9.2 opine (forked from master ~9 hours ago, latest version 0.18.0)

I've updated the following:

CheckList

srepollock commented 4 years ago

I should explicitly note that this is a breaking change from deno 1.1.3 to 1.2.0.

github-actions[bot] commented 4 years ago

Benchmark results

PR to merge hotfix/42 0fcc0c31b714bb11e9a641aace9c909dabeee7f8 -> main ``` 1 middleware 7208.50 RPS 5 middleware 6930.61 RPS 10 middleware 6566.55 RPS 15 middleware 7055.56 RPS 20 middleware 6919.41 RPS 30 middleware 6887.83 RPS 50 middleware 6466.18 RPS 100 middleware 5756.63 RPS ```
asos-craigmorten commented 4 years ago

Will get this released and tagged in 0.19.0