cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.

https://github.com/cmorten/opine/blob/main/.github/API/api.md

MIT License

854 stars 43 forks source link

[#44] react and dejs examples not working #47

Closed FaberVitale closed 4 years ago

FaberVitale commented 4 years ago

Issue

#44

Details

Fixes #44

Resolves #44 and updates the following deps:
- dejs 0.70 -> 0.8.0 in examples/
- evt 1.7.13 -> 1.8.0
- http_errors 2.0.0 -> 2.10
These updates have the benefit of removing unversioned deno.land/std dependencies.
set deno_version in test.yml to 1.2.1
ran deno fmt; we should exclude docs/* path.

I've looked into an importmap solution but I don't think support from the vscode extension is good enough and importmap feature seems quite limiting in ts current implementation.

CheckList

[x] PR starts with [#44].
[x] Has been tested (where required) before merge to main.

github-actions[bot] commented 4 years ago

Benchmark results

PR to merge fix/issue-44-react-and-dejs-examples-not-working 6098110c34a0b866aa6dfe6249d0e7c554143fa2 -> main

``` 1 middleware 8703.24 RPS 5 middleware 8700.46 RPS 10 middleware 8587.74 RPS 15 middleware 8397.83 RPS 20 middleware 7793.66 RPS 30 middleware 7859.05 RPS 50 middleware 7364.30 RPS 100 middleware 6613.02 RPS ```

asos-craigmorten commented 4 years ago

Looking good.

I think importmap is still unstable and not 100% convinced whether it’s here to stay yet. We could consider deps.ts...

Think there are a few other references to Deno 1.2.0 that are likely worth upgrading to latest as well.

deno fmt suggestion sounds good.

FaberVitale commented 4 years ago

Looking good.

I think importmap is still unstable and not 100% convinced whether it’s here to stay yet. We could consider deps.ts...

We'd force users to download react, react-dom, dejs, swagger etc... just to test a json response or a redirect: Imo, It wouldn't be the best 1st impression.

asos-craigmorten commented 4 years ago

We'd force users to download react, react-dom, dejs, swagger etc... just to test a json response or a redirect: Imo, It wouldn't be the best 1st impression.

Agree