cmorten / opine

Minimalist web framework for Deno ported from ExpressJS.

https://github.com/cmorten/opine/blob/main/.github/API/api.md

MIT License

854 stars 43 forks source link

(fix) deno 1.4.0 : export type #67

Closed 0xtlt closed 4 years ago

0xtlt commented 4 years ago

Issue

With Deno 1.4.0 a problem prevents the library from being used and makes it necessary to use the "--isolatedModules" entry to work.

Details

I changed all the exports and imports that were types to make it work.
But libraries that Opine uses currently have the same problem, I am also looking at PRs fixes for their libs

github-actions[bot] commented 4 years ago

Benchmark results

PR to merge main b717cdf65b29cd0ac65d988372522fdc6647e637 -> main

``` 1 middleware 8228.37 RPS 5 middleware 8061.78 RPS 10 middleware 7841.06 RPS 15 middleware 7577.31 RPS 20 middleware 7606.93 RPS 30 middleware 7181.54 RPS 50 middleware 7036.13 RPS 100 middleware 6094.06 RPS ```

asos-craigmorten commented 4 years ago

Hey @ThomasT404! 👋🏻

Thanks so much 😄 on my todo list but not got round to it!

Look forward to seeing the deps fixed up so we can get this in!

jvmazagao commented 4 years ago

A lot of checks are broken, can anyone fix this merge?

0xtlt commented 4 years ago

A lot of checks are broken, can anyone fix this merge?

I just fixed the lock.json file 😄