Closed DxSimonovski closed 3 years ago
@asos-craigmorten not very savvy around PRs so please correct me where needed or entirely disregard, I just want to help where possible :)
Hey @DxSimonovski thanks for this! 🚀
I’m a little stacked atm so bare with me as might be slow to respond.
This looks great! CI is failing on lock files it looks like so, please can you run make lock
(or copy and run the command in the Makefile if don’t have make on your machine) so we can get the test suite running as well.
One thing keen to have if this is to drop, is the ability to access the original body property via some raw
so consumers don’t lose access to it. For backwards compatibility it would also be good to support and have a test asserting the parsedBody
property still getting populated.
I’ll try and give the changes a proper review a bit later.
@DxSimonovski apologies been slow getting around to looking at this!
Really excited to see this land - left a few comments and think need a merge down from main
to get the CI green again.
Superceded by https://github.com/asos-craigmorten/opine/pull/95
Issue
#26
Details
Added a converter method which returns a proxied version of the Request object to be used in middlewares so req.body resembles parsed value stored in req.parsedBody.
CheckList