search

cmoscardi / lilite

Lilite: A Linux package installer
https://www.lilite.co
10 stars 2 forks source link

[DEBUG] chrome sources #32

Closed cmoscardi closed 6 years ago

cmoscardi commented 6 years ago

Mailspring will probably be down here too. I'll try again later.

cmoscardi commented 6 years ago

Fixed with alternative Chrome install method

karanrajpal14 commented 6 years ago

This issue mainly occurs because Chrome adds it's PPA info in a separate file and so are we. We can either delete the file that Chrome makes, which is what I tried but it didn't go so well. Or what we can do is directly create that file so that Chrome doesn't have to. That's what I came up with but it wasn't an ideal solution so I didn't go ahead with it.

As long as Chrome can be updated via apt, this solution works as well. Thank you for fixing it @cmoscardi !

cmoscardi commented 6 years ago

Yep. According to the chrome docs, the deb adds a PPA during its install. So I wonder if what was happening was that upon install, the chrome installer was double-adding it bascially.

Christian

On Sat, Feb 24, 2018 at 9:15 PM, Karan M Rajpal notifications@github.com wrote:

This issue mainly occurs because Chrome adds it's PPA info in a separate file and so are we. We can either delete the file that Chrome makes, which is what I tried but it didn't go so well. Or what we can do is directly create that file so that Chrome doesn't have to. That's what I came up with but it wasn't an ideal solution so I didn't go ahead with it.

As long as Chrome can be updated via apt, this solution works as well. Thank you for fixing it!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cmoscardi/lilite/pull/32#issuecomment-368277033, or mute the thread https://github.com/notifications/unsubscribe-auth/ABC3dbUgNwrX055po_kLZ86EkK4lSgFaks5tYMIogaJpZM4SR-jJ .

karanrajpal14 commented 6 years ago

Yeah that's the best possible explanation. Hopefully, it doesn't happen now.

Also, in case you haven't noticed, the build failed @cmoscardi

cmoscardi commented 6 years ago

Yeah thanks. Mailspring kept dying over the weekend with intermittent http errors. One of the two did succeed. Trying again.

Christian

On Sun, Feb 25, 2018 at 8:49 PM, Karan M Rajpal notifications@github.com wrote:

Yeah that's the best possible explanation. Hopefully, it doesn't happen now.

Also, in case you haven't noticed, the build failed @cmoscardi https://github.com/cmoscardi

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cmoscardi/lilite/pull/32#issuecomment-368367734, or mute the thread https://github.com/notifications/unsubscribe-auth/ABC3df1JrdoqSPHgBxISbxJMmk6rD8jFks5tYg2QgaJpZM4SR-jJ .

karanrajpal14 commented 6 years ago

It did succeed. Not sure why the builds were failing though. I'll get in touch with them if it happens again. You can go ahead and deploy the changes now @cmoscardi