cmower / optas

OpTaS: An optimization-based task specification library for trajectory optimization and model predictive control.

https://cmower.github.io/optas/

Other

99 stars 14 forks source link

Add checking if joint is in chain #141

Closed joaomoura24 closed 1 year ago

joaomoura24 commented 1 year ago

Description

Describe the additions made in this pull request.

Todo

[x] Completed implementation of new feature.
[ ] Add documentation for the new feature.
[ ] Ensure all unit tests pass.
[ ] Address all issues raised by unit-tests.
[x] Added code reviewer.

cmower commented 1 year ago

I didn't check too much the code, but all the unit-tests are passing so the Jacobian should be computed correctly - perhaps we can add a unit test for dual arm (using the nextage) in a separate PR. If this solves @duISIR's issue then I'm happy for @joaomoura24 to merge directly.

joaomoura24 commented 1 year ago

Ok, then I will go ahead and merge. I'll add an issue for adding unit test for dual arm in case we want to start using more serious work on it, but not for the next month.