search

cmpute / dashu

A library set of arbitrary precision numbers implemented in Rust.
Apache License 2.0
76 stars 9 forks source link

Missing functionality in scryer #35

Closed fayeed closed 1 year ago

fayeed commented 1 year ago

@cmpute This PR includes all the missing functionality that the Scryer needs that I had to add, please let me know if the implementation makes sense to you or needs to be updated.

cmpute commented 1 year ago

And I apologize that the documentations for dashu are pretty bad right now. I do plan to write a guide about how to use these crates, but I haven't finished it yet, and I expect it to take another 3 months or so..

fayeed commented 1 year ago

@cmpute No worries, I am still a beginner in Rust, Scryer & Dashu was the first proper Rust codebase I looked through missed a lot of things, anyway Thanks for the help with this.

fayeed commented 1 year ago

@cmpute How do I compare RBig with IBig looks like only IBig implements NumOrd, thanks.

cmpute commented 1 year ago

@cmpute How do I compare RBig with IBig looks like only IBig implements NumOrd, thanks.

Ah yes, I'm working on implementing that between Ubig/IBig and Rbig

cmpute commented 1 year ago

The latest commit on the dashu repo now contains the implementation of NumOrd<IBig> for RBig.

cmpute commented 1 year ago

I have completed all the break changes I would like to include in the next version (v0.4) of dashu and it's ready for release. You can compose the PR based on the latest commit on the master branch. I would like to coordinate with you and see if you want to see more features to the next release of dashu. Thanks.

fayeed commented 1 year ago

Hey, I have a PR open with the master on Scryer now, was able to get everything working, if you can release a new version I could update the PR with it, thanks.

cmpute commented 1 year ago

I have released the v0.4 of dashu crates. Thanks for your work on Scryer side!