Open eduardosm opened 1 year ago
This is the change (compared to the master branch) measured on my PC:
In summary main regressions come from ubig_gcd_ext
and ubig_from_hex
, improvements come from ubig_div
and ubig_from_dec
. It seems pretty weird to me..
It will be great if you can provide some benchmark results on your computer. (just run cargo bench -p dashu-int --bench primitive --features rand
)
I rebased on top of latest master and ran the benchmark (first on master and then on my branch):
-40% in ubig_pow/100? I ran it again
So it looks like it was a huge outlier as a whole...
It seems that the benchmark needs improving... I will try this PR before the next major version release, when I will compare again the performance of dashu
against other libraries.
Thanks for the proposal! I'm not sure if this change results in a performance change, I will merge it after I have a better benchmark implementation, and confirmed that this won't result in performance regression.