search

cmpute / num-modular

Apache License 2.0
13 stars 4 forks source link

Improve bignum support (Closes: #9) #10

Open sylvestre opened 3 months ago

sylvestre commented 3 months ago

@cmpute if you could approve the CI run, it would be great, thanks :)

cmpute commented 3 months ago

Thanks for the PR! The CI test failed. The MSRV policy is still 1.57.

sylvestre commented 3 months ago

@cmpute is there a reason for 1.57 as a minimal dep ? it is quite old now (almost 3 years now)

cmpute commented 3 months ago

@cmpute is there a reason for 1.57 as a minimal dep ? it is quite old now (almost 3 years now)

Not much, but I don't think it's worth to bump the MSRV only for the 'dep:' feature tho.

sylvestre commented 1 month ago

@cmpute I think I fixed it

I am trying to package num-prime in debian for the rust coreutils :) This is why I need this bug fixed

cmpute commented 1 month ago

The 1.57 check still failed. I will take a look later

cmpute commented 1 month ago

There is a work around, you can build with "--features num-bigint,num-traits,num-integer".

If it doesn't work for you, then I think the only way is to rename the "num-bigint" dependency, which might requires additional checks on other packages depending on this.

sylvestre commented 1 month ago

ok, thanks :)

the only way

or upgrade MSRV ;)

cmpute commented 1 month ago

ok, thanks :)

the only way

or upgrade MSRV ;)

Yeah the only way without bumping MSRV haha. Please let me know if enabling all these three features num-bigint,num-traits,num-integer works for you or not. If it suffices, I prefer to close the PR and the issue.