search

cmrigney / node-sftp-s3

Node JS module for creating an SFTP server that uses S3 for file storage.
MIT License
23 stars 18 forks source link

Handle REALPATH "" #10

Closed ddrinka closed 7 years ago

ddrinka commented 7 years ago

REALPATH / is handled but REALPATH "" is not. This change makes either request return the root directory's REALPATH.

JoergAdler commented 7 years ago

Is there any problem with that pull request? At the moment, this bug prevents our Java-Backend to put files. (as you can see here https://github.com/is/jsch/blob/master/src/com/jcraft/jsch/ChannelSftp.java the jsch package makes a REALPATH of "" to determine the home directory)

Would be nice, if you could consider merging it :-)

cmrigney commented 7 years ago

Are the tests passing on your machine? Looks like test 3 is failing on CI for some reason.

cmrigney commented 7 years ago

I'll merge it once I find out what the tests issue is.