cmroche / OctoPrint-HomeAssistant

Home Assistant plugin for OctoPrint, enabling MQTT discovery of you device and sensors
110 stars 18 forks source link

3.3.1 breaks HA integration for me #81

Closed halfluck closed 2 years ago

halfluck commented 2 years ago

Hey Guys,

since the 3.3.1 update my HA does not see any of my instances, i've tried a clean uninstall and new install of 3.3.1 with no luck, i've also tried installing cmroche version of OctoPrint-MQTT incase there was a compatibility issue with the main branch of OctoPrint-MQTT. When i roll back to 3.3.0 everything works as expected.

HA Core 2021.10.5 OctoPrint 1.7.0 Python 3.7.3 OctoPi 0.18.0

Rob.

oerkel47 commented 2 years ago

Yep there is an error in the logs after updating to 3.3.1:

2021-10-17 18:51:44,942 - octoprint.plugin - ERROR - Error while calling plugin homeassistant Traceback (most recent call last): File "/octoprint/plugins/lib/python3.8/site-packages/octoprint/plugin/__init__.py", line 271, in call_plugin result = getattr(plugin, method)(*args, **kwargs) File "/octoprint/plugins/lib/python3.8/site-packages/octoprint/util/__init__.py", line 1737, in wrapper return f(*args, **kwargs) File "/octoprint/plugins/lib/python3.8/site-packages/octoprint_homeassistant/__init__.py", line 110, in on_after_startup if not settings().get_boolean( AttributeError: 'Settings' object has no attribute 'get_boolean'

cmroche commented 2 years ago

That's very strange... but thanks for raising it, I'll look asap.

cmroche commented 2 years ago

@halfluck , @oerkel47

Figured out the issue, sorry about the break but should be fixed again on 3.3.2 which is available any moment now.

halfluck commented 2 years ago

Amazing, love your work!