search

cmroche / greeclimate

Python package for controlling Gree based minisplit systems
GNU General Public License v3.0
44 stars 22 forks source link

Fahrenheit Conversion Raises StopIteration #72

Closed mag2352 closed 4 months ago

mag2352 commented 5 months ago

I've noticed this issue for a while now, and not sure if anyone else took a look at this error. I'd like to note that I have a Gree Livo GEN4 system, so this might be isolated to this system. I am using HomeAssistant, with the built in Gree integration to control the units. I believe that there is some difference in the way that units are being converted between the internal system and this python package. In addition, whenever this StopIteration error is raised, this prevents climate entities from being initiated, as shown below. When using other integrations, like BetterThermostat (which change the target temperature frequently), these errors will cause HomeAssistant to eventually crash.

2024-05-14 14:59:32.495 ERROR (MainThread) [homeassistant.components.climate] Error adding entity climate.9424b87e771f for domain climate with platform gree

Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1334, in add_to_platform_finish self.async_write_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 998, in async_write_ha_state self._async_write_ha_state() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1119, in _async_write_ha_state state, attr, capabilities, shadowed_attr = self.async_calculate_state() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1058, in async_calculate_state attr.update(self.state_attributes or {}) ^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/climate/init.py", line 328, in getattribute return super().getattribute(name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/climate/init.py", line 526, in state_attributes self.target_temperature, ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/climate/init.py", line 328, in getattribute return super().getattribute(name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/gree/climate.py", line 150, in target_temperature return self.coordinator.device.target_temperature ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/greeclimate/device.py", line 357, in target_temperature return self._convert_to_units(temSet, temRec) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/greeclimate/device.py", line 350, in _convert_to_units f = next(t for t in TEMP_TABLE if t["temSet"] == value and t["temRec"] == bit) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ StopIteration

The specific instance I've captured is this packet from the unit giving the problem:

2024-05-14 14:59:32.485 DEBUG (MainThread) [greeclimate.network] Received packet: {"t": "pack", "i": 0, "uid": 0, "cid": "9424b87e771f", "tcid": "app", "pack": {"t": "dat", "uid": 0, "mac": "9424b87e771f", "cid": "9424b87e771f", "dat": [0, 1, 0, 0, 0, 0, 0, 25, 64, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], "cols": ["Pow", "Mod", "Dwet", "DwatSen", "Dfltr", "DwatFul", "Dmod", "SetTem", "TemSen", "TemUn", "TemRec", "WdSpd", "Air", "Blo", "Health", "SwhSlp", "SlpMod", "Lig", "SwingLfRig", "SwUpDn", "Quiet", "Tur", "StHt", "SvSt", "HeatCoolType"], "r": 200}}

Evidently, the unit is reporting a temSet of 25, and a temRec of 1. The generated table of this python package doesn't have this value, and will raise the StopIteration error. I confirmed that if I pick a value that is in the table, HomeAssistant stops complaining, and adds the climate entity as expected.

mag2352 commented 5 months ago

I created a PR that just picks the closest value in the generated table. This resolves the issue more or less, and unless someone wants to dedicate more time, this is workable for my use case.