search

cmroche / greeclimate

Python package for controlling Gree based minisplit systems
GNU General Public License v3.0
42 stars 21 forks source link

Fahrenheit Conversion Inconsistencies #73

Closed mag2352 closed 3 months ago

mag2352 commented 4 months ago

I understand that this is a hacky way of resolving the StopIteration problems, but this resolves the issue I have in #72. Unless someone can dedicate significant time into determining how the conversion process differs, this is enough to allow HomeAssistant to function as expected with the Gree units that I have, and this PR should not cause any issues for those who don't have these problems.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.98%. Comparing base (db819b4) to head (2b100f6). Report is 2 commits behind head on master.

:exclamation: Current head 2b100f6 differs from pull request most recent head 51371ec

Please upload reports for the commit 51371ec to get more accurate results.

Files Patch % Lines
greeclimate/device.py 81.81% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #73 +/- ## ========================================== - Coverage 92.18% 91.98% -0.21% ========================================== Files 5 5 Lines 678 686 +8 ========================================== + Hits 625 631 +6 - Misses 53 55 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cmroche commented 3 months ago 
=========================== short test summary info ============================
FAILED tests/test_device.py::test_send_temperature_out_of_range_farenheit_get[100] - assert 140 == 68
======================== 1 failed, 85 passed in 45.68s =========================

Have to remove some of the now valid ranges :)

mag2352 commented 3 months ago

Wasn't sure if I should have touched those test cases - Thanks.

cmroche commented 3 months ago

Wasn't sure if I should have touched those test cases - Thanks.

No worries, looks good. I'll merge soon. Thanks for the updates.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: