More SiStrips ES get() calls

[tvami]

• CalibTracker/SiStripESProducers

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CalibTracker/SiStripESProducers/test/testSiStripQualityESProducer.cc:33:69: warning: 'bool edm::eventsetup::EventSetupRecord::get(const string&, HolderT&) const [with HolderT = edm::ESHandle<SiStripQuality>; std::string = std::__cxx11::basic_string<char>]' is deprecated [-Wdeprecated-declarations]
  33 |   iSetup.get<SiStripQualityRcd>().get(dataLabel_, SiStripQualityESH_);

  and

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CalibTracker/SiStripESProducers/test/testSiStripQualityESProducer.cc:43:77: warning: 'bool edm::eventsetup::EventSetupRecord::get(const string&, HolderT&) const [with HolderT = edm::ESHandle<SiStripQuality>; std::string = std::__cxx11::basic_string<char>]' is deprecated [-Wdeprecated-declarations]
  43 |     iSetup.get<SiStripQualityRcd>().get(dataLabelTwo_, twoSiStripQualityESH_);

  and

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CalibTracker/SiStripESProducers/test/CheckPhase2Cabling.cc:94:58: warning: 'bool edm::eventsetup::EventSetupRecord::get(HolderT&) const [with HolderT = edm::ESHandle<Phase2TrackerCabling>]' is deprecated [-Wdeprecated-declarations]
  94 |   iSetup.get<Phase2TrackerCablingRcd>().get(cablingHandle);

  then

• CalibTracker/SiStripDCS

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CalibTracker/SiStripDCS/test/Synchronization/SyncDCSO2O.cc:92:46: warning: 'bool edm::eventsetup::EventSetupRecord::get(HolderT&) const [with HolderT = edm::ESHandle<SiStripDetVOff>]' is deprecated [-Wdeprecated-declarations]
  92 |   iSetup.get<SiStripDetVOffRcd>().get(detVOff);

  and

  • CalibFormats/SiStripObjects

    /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CalibFormats/SiStripObjects/test/plugins/testSiStripHashedDetId.cc:46:50: warning: 'bool edm::eventsetup::EventSetupRecord::get(HolderT&) const [with HolderT = edm::ESHandle<TrackerGeometry>]' is deprecated [-Wdeprecated-declarations]
    46 |   setup.get<TrackerDigiGeometryRecord>().get(geom);

    and

• CondFormats/PhysicsToolsObjects

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDx2DReader.cc:41:60: warning: 'bool edm::eventsetup::EventSetupRecord::get(HolderT&) const [with HolderT = edm::ESHandle<PhysicsTools::Calibration::VHistogramD2D>]' is deprecated [-Wdeprecated-declarations]
  41 |   iSetup.get<SiStripDeDxProton_2D_Rcd>().get(SiStripDeDx2D_);

  and

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDx3DReader.cc:41:60: warning: 'bool edm::eventsetup::EventSetupRecord::get(HolderT&) const [with HolderT = edm::ESHandle<PhysicsTools::Calibration::Histogram3D<double> >]' is deprecated [-Wdeprecated-declarations]
  41 |   iSetup.get<SiStripDeDxProton_3D_Rcd>().get(SiStripDeDx3D_);

  and

  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/f0e520f39471b6d35db786db8917f45a/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/src/CondFormats/PhysicsToolsObjects/test/SiStripDeDxMipReader.cc:19:54: warning: 'bool edm::eventsetup::EventSetupRecord::get(HolderT&) const [with HolderT = edm::ESHandle<PhysicsTools::Calibration::Histogram2D<double> >]' is deprecated [-Wdeprecated-declarations]
  19 |   iSetup.get<SiStripDeDxMipRcd>().get(SiStripDeDxMip_);

[tvami]

@mmusich is there a point in tagging the Strips people? :)

[robervalwalsh]

Hi @tvami, could you please give more details of what the issue is? Thanks!

[mmusich]

@robervalwalsh shall we maybe have a short chat?

[robervalwalsh]

@mmusich, yes

[mmusich]

was actually quite straightforward to do, so here it is: https://github.com/cms-sw/cmssw/pull/36015

[tvami]

resolved in https://github.com/cms-sw/cmssw/pull/36015