search

cms-DQM / CentralHDQM

Central CMS Historic DQM application
https://cms-hdqm.web.cern.ch
0 stars 12 forks source link

Add GEM elements in HDQM #33

Closed SeungJunLee0 closed 3 years ago

SeungJunLee0 commented 3 years ago

i add the GEM elements in HDQM.

if it cause problem, please send the mail to me.

seungjun.lee@cern.ch seungjunlee15@gmail.com

jfernan2 commented 3 years ago

@SeungJunLee0 is the PR final? Have you tested it somehow?

SeungJunLee0 commented 3 years ago

@jfernan2 yep. i ran the HDQM locally.
what is the PR??

스크린샷 2021-02-16 오전 3 57 12
jfernan2 commented 3 years ago

PR = Pull Request :-) I saw you made a commit just an hour ago, I wonder if the changes are kind of final or if you expect to commit more changes.

SeungJunLee0 commented 3 years ago

@jfernan2 Thanks. but it isnt final PR. because MWGR doesnt finish. when new gem elements add in new MWGR or run data, i will implement them.

jfernan2 commented 3 years ago

OK, so then we wait for merging until you commit all the changes. Thanks