search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Quick fix to add back track quality for tracks produced by new KF #102

Closed Jingyan95 closed 2 years ago

Jingyan95 commented 2 years ago

@tschuh

tschuh commented 2 years ago

there is a space too much in front of trkMVA3. That code change would pass the trkMVA values produced by tracklet pattern reco to the KF output, is that what you want?

Jingyan95 commented 2 years ago

there is a space too much in front of trkMVA3. That code change would pass the trkMVA values produced by tracklet pattern reco to the KF output, is that what you want?

OK, I just realized the track quality here is produced by tracklet with raw parameter. We need track quality produced by fitted parameters.

tschuh commented 2 years ago

Did we not have that in the past? Got that lost during the merge from cmssw 11 to 12?

Jingyan95 commented 2 years ago

Did we not have that in the past? Got that lost during the merge from cmssw 11 to 12?

I was looking at the old ntuples I produced with cmssw 11 and I didn't see trk_MVA1 being filled. I would assume track quality has been missing from KFout tracks since the beginning?

tschuh commented 2 years ago

that may be, but somehow this is ringing a bell in my mind.