cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Summerchain new KF #107

Closed tschuh closed 3 years ago

tschuh commented 3 years ago

This PR does:

tomalin commented 3 years ago

Please clarify in more detail above what this is doing. The existing code is already capable of writing .txt files corresponding to the digitized input of the IR & output of the TB. I assume that ProducerTBout is solving issue https://github.com/cms-L1TK/cmssw/issues/101 ? I assumed SummerChain_cfg.py adds the functionality to check on the fly if ModelSim & CMSSW agree. But this means that the FW to be used must be specified somewhere? What is meant by "adding the Summer Chain cfg" of the new KF? This is a very big PR, touching 28 files, so we need a much more detailed understanding of it before merging. I recommend a talk in next L1TrkAlgo meeting.

tomalin commented 3 years ago

Proposal: 1) Separate bug fixes into small PR, that we can approve quickly. 2) Consider if ProducerTBout can obtain digi data directly from digi data in Tracklet pattern reco (e.g. where it writes this data to .txt file), rather than by digitizing floating point output of tracklet pattern reco from TTTracks. 3) The setting of params such as "doMultipleMatches_" for comparison with FW may be duplicating the change Anders proposes in his PR. Check once that is merged. 4) Eliminate SummerChain_cfg.py, by adding a python boolean "isSummerChain" to demonstrator_cfg.py. 5) We should not have duplicate constants. So if these two items above are duplicating constants, they need a rethink: (a) "adds a map of which DTC links are used in summer chain configuration as python config" (b) "adds seed type names, seeding layer Ids per seed type and projection layers per seed type as python config". 5) Give talk(s) at L1TrkAlgo explaining need for ProducerIRin & ProducerTBout. 6) Give talk at HLS or L1TrkAlgo meeting explaining your alternative way of doing FW vs SW comparison without txt file output. Clarify if we can produce txt files corresponding to output of KF stages. And if we can use your method of FW vs SW comparison for testing internal IR to TB stages.

tschuh commented 3 years ago

I replaced this PR by