summer chain demonstrator

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.

http://cms-sw.github.io/

Apache License 2.0

4 stars 5 forks source link

summer chain demonstrator #111

Closed tschuh closed 2 years ago

tschuh commented 3 years ago

This PR does:

updates default Demonstrator_cfi.py parameter to run summer chain demonstration
adds StreamsStub as new EDProduct to L1FPGATrackProducer
adds new File ProducerIRin which transforms the TTDTC object in the same f/w near format as used in KF, KFin (output only atm), KFout which enables the use of Demonstrator to compare hybrid s/w with f/w
add new File ProducerTBout which transforms found TTTracks and StreamsStub in the same f/w near format as used in ProducerIRin which serves as input of KFin in future and enables the use of Demonstrator to compare tracklet pattern reco s/w with f/w

This PR depends on https://github.com/cms-L1TK/cmssw/pull/110 This PR allows me to compare s/w with f/w for any event

tomalin commented 2 years ago

Since Demonstrator.cc is used to test both Hybrid & TMTT, consider: 1) Moving Demonstrator.cc, .h & _cfi.py to TrackTrigger/ , where the _cfi.py file would have dummy values, such as "LabelIn = cms.string("InputEDProductName") 2) Add Demonstrator_cff.py to both TrackerTFP/python/ and TrackFindingTracklet/python/ . It would read in Demonstrator_cfi.py and override the dummy values there with the correct ones or Hybrid & TMTT.

tomalin commented 2 years ago

@tschuh I'm ready to approve this, except that a few comments above have not been responded to.

tschuh commented 2 years ago

sorry, somehow missed that there are outstanding comments.

tomalin commented 2 years ago

After answering the trivial remaining comments above, the git complaint about "conflicts" needs resolving. I suspect this can be done by following the instructions in https://twiki.cern.ch/twiki/bin/view/CMS/L1TrackSoftware obtained under the heading "If other people have made changes the code above since you checked it out" for "(c) complicated case".

tomalin commented 2 years ago

Since Demonstrator.cc is used to test both Hybrid & TMTT, consider:

Moving Demonstrator.cc, .h & _cfi.py to TrackTrigger/ , where the _cfi.py file would have dummy values, such as "LabelIn = cms.string("InputEDProductName")

Add Demonstrator_cff.py to both TrackerTFP/python/ and TrackFindingTracklet/python/ . It would read in Demonstrator_cfi.py and override the dummy values there with the correct ones or Hybrid & TMTT.

@tschuh any thoughts on this comment?

tschuh commented 2 years ago

the values of hybrid demonstrator will be modified with a customize function living in TrackFindingTracklet in future. I would move Demonstrator to TrackTrigger if I can use it for the DTC.