Closed bryates closed 2 years ago
@bryates github is saying above your code has conflicts. Perhaps you didn't start from the latest cms-L1TK:L1TK-dev-12_0_0_pre4 ?
@bryates github is saying above your code has conflicts. Perhaps you didn't start from the latest cms-L1TK:L1TK-dev-12_0_0_pre4 ?
My mistake, I used L1TK-dev-12_0_0_pre4
instead of cms-L1TK/L1TK-dev-12_0_0_pre4
. I just rebased and pushed.
@tomalin It looks like the CI failed. Is this because I used a fork? The CMSSW instructions indicated to use a fork, but I can just push a branch to this repo instead.
You must put your branch in cms-L1TK, not your personal repo, or CI will fail due to access rights.
Closing this PR since it was made on my fork.
PR description:
This PR fixes the agreement with the HLS implementation of the MatchCalculator by dropping the number of iterations to 104.
PR validation:
We noticed a single
FullMatch
in event 43 was missing in the HLS implementation:After recreating the test vectors with this PR, we see full agreement:
This is the only event that changes.