search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Reduced MC to 104 iterations #123

Closed bryates closed 2 years ago

bryates commented 2 years ago

PR description:

This PR fixes the agreement with the HLS implementation of the MatchCalculator by dropping the number of iterations to 104.

PR validation:

We noticed a single FullMatch in event 43 was missing in the HLS implementation:

Event: 43
FullMatch 1:
index   reference   computed
0   0x620922b00301a 0x620922b00301a
1   0x622129c5f91c6 0x622129c5f91c6
2   0x64090f15f31b1 0x64090f15f31b1
3   0x640d0f15f3186 0x640d0f15f3186
4   0x641d2d39fb031 0x641d2d39fb031
5   0x64212d39fc1cc 0x0 <=== missing
@E Simulation failed: Function 'main' returns nonzero value '1'.
ERROR: [SIM 211-100] 'csim_design' failed: nonzero return value.
INFO: [SIM 211-3] *************** CSIM finish ***************

After recreating the test vectors with this PR, we see full agreement:

Event: 43
FullMatch 1:
index   reference       computed
0       0x620922b00301a 0x620922b00301a
1       0x622129c5f91c6 0x622129c5f91c6
2       0x64090f15f31b1 0x64090f15f31b1
3       0x640d0f15f3186 0x640d0f15f3186
4       0x641d2d39fb031 0x641d2d39fb031
INFO: [SIM 211-1] CSim done with 0 errors.
INFO: [SIM 211-3] *************** CSIM finish ***************

This is the only event that changes.

tomalin commented 2 years ago

@bryates I'm merging this. Please Email Andrew to tell him to remake the test data (again ...)