search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

MP cleanup 220208 + MC fix #133

Closed bryates closed 2 years ago

bryates commented 2 years ago

PR description:

This PR brings the emulation back into agreement with the HLS implementation of the MP. This includes properly emulating the manual pipelining implemented in HLS.

It also fixes the MC.

PR validation:

Full agreement in all MP barrel layers

tomalin commented 2 years ago

Will the emulation fix to the MC, needed to give agreement with HLS, be submitted as a separate PR?

bryates commented 2 years ago

Will the emulation fix to the MC, needed to give agreement with HLS, be submitted as a separate PR?

@aryd have you pushed the MC updates, or were all those fixes just in the HLS implementation?

tomalin commented 2 years ago

The git CI does not validate the hybrid tracking using the combined modules. Please confirm that you've used L1TrackNtuplePlot.C to check that after this code change, the tracking performance from the summary printout is roughly unchanged. e.g. Efficiency = ~95%.

bryates commented 2 years ago

The git CI does not validate the hybrid tracking using the combined modules. Please confirm that you've used L1TrackNtuplePlot.C to check that after this code change, the tracking performance from the summary printout is roughly unchanged. e.g. Efficiency = ~95%.

It looks like that script relies on cvmfs, which the server I'm running on does not mount. I've put a copy of the output root file here: https://byates.web.cern.ch/byates/TTbar_PU200_D76.root if @aryd or @tomalin has time to run L1TrackNtuplePlot.C over it quickly. Otherwise, I can try to set up the environment on lxplus.

tomalin commented 2 years ago

https://byates.web.cern.ch/byates/TTbar_PU200_D76.root

Unfortunately, if I do: curl -k -O https://byates.web.cern.ch/byates/TTbar_PU200_D76.root root TTbar_PU200_D76.root Then ROOT tells me that "file TTbar_PU200_D76.root probably not closed". This file is 1.8MB, but I can't read it.

aryd commented 2 years ago

I have just now pushed the changes for the MC in the emulation to the MP_cleanup_220208 branch. I’m doing some check to make sure this is OK. (I guess you rebased this branch? I picked up a number of other changes when I did a ‘git pull’….)

-Anders

Anders Ryd @.**@.>

On Feb 15, 2022, at 2:01 PM, Brent R. Yates @.**@.>> wrote:

Will the emulation fix to the MC, needed to give agreement with HLS, be submitted as a separate PR?

@arydhttps://github.com/aryd have you pushed the MC updates, or were all those fixes just in the HLS implementation?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-L1TK/cmssw/pull/133#issuecomment-1040669355, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTOTP5Y4DCLU4JCSXBTU3KPHDANCNFSM5OPKST5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

aryd commented 2 years ago

Yes this is the convention I invented for pipeline variable. I have used this both on the C++ emulation and HLS. Don’t know if there is a better way to name these?

-Anders

Anders Ryd @.**@.>

On Feb 15, 2022, at 2:06 PM, Brent R. Yates @.**@.>> wrote:

@bryates commented on this pull request.

In L1Trigger/TrackFindingTracklet/interface/MatchEngineUnit.hhttps://github.com/cms-L1TK/cmssw/pull/133#discussion_r807212802:

@@ -95,13 +101,22 @@ namespace trklet { //LUT for bend consistency with rinv const TrackletLUT& luttable_;

These are the pipelined variables, so each underscore corresponds to the pipeline depth.

— Reply to this email directly, view it on GitHubhttps://github.com/cms-L1TK/cmssw/pull/133#discussion_r807212802, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTKWDL74ZGLDTP325HTU3KP3BANCNFSM5OPKST5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

aryd commented 2 years ago

OK - the latest code does not seem to run.

I’m running:

cmsRun L1TrackNtupleMaker_cfg.py

and it fails with:

Thread 1 (Thread 0x7f12781e4540 (LWP 5822)):

0 0x00007f127a07dddd in poll () from /lib64/libc.so.6

1 0x00007f1273ed67b7 in full_read.constprop () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so

2 0x00007f1273ed70ec in edm::service::InitRootHandlers::stacktraceFromThread() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so

3 0x00007f1273eda59b in sig_dostack_then_abort () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so

4

5 0x00007f1222f43af0 in edm::eventsetup::CallbackProxy<edm::eventsetup::Callback<trackerDTC::ProducerLayerEncoding, std::unique_ptr<trackerDTC::LayerEncoding, std::default_delete >, trackerDTC::LayerEncodingRcd, edm::eventsetup::CallbackSimpleDecorator >, trackerDTC::LayerEncodingRcd, std::unique_ptr<trackerDTC::LayerEncoding, std::default_delete > >::invalidateCache() () from /afs/cern.ch/work/a/aryd/public/12_0_0_pre4_MP_Fixes/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginTrackerDTCPlugins.sohttp://cern.ch/work/a/aryd/public/12_0_0_pre4_MP_Fixes/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginTrackerDTCPlugins.so

6 0x00007f127cbe6aa1 in edm::eventsetup::EventSetupRecordImpl::invalidateProxies() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

7 0x00007f127cbe4930 in edm::FunctorWaitingTask<edm::eventsetup::EventSetupRecordIOVQueue::startNewIOVAsync(edm::WaitingTaskHolder const&, edm::WaitingTaskList&)::{lambda(edm::LimitedTaskQueue::Resumer)#1}::operator()(edm::LimitedTaskQueue::Resumer)::{lambda(std::__exception_ptr::exception_ptr const*)#1}>::execute() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

8 0x00007f127cb6950f in tbb::detail::d1::function_task<edm::WaitingTaskHolder::doneWaiting(std::__exception_ptr::exception_ptr)::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

9 0x00007f127b3afd0b in tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::external_waiter> (this=0x7f1276b5be00, t=0x7f1276a16700, waiter=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.h:396

10 0x00007f127b3ac7e5 in tbb::detail::r1::task_dispatcher::local_wait_for_all (waiter=..., t=0x0, this=0x7f1276b5be00) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.cpp:178

11 tbb::detail::r1::task_dispatcher::execute_and_wait (t=0x0, wait_ctx=..., w_ctx=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.cpp:168

12 0x00007f127cb8fdb6 in edm::EventProcessor::taskCleanup() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

13 0x000000000040bb2c in tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const ()

14 0x00007f127b394970 in tbb::detail::r1::task_arena_impl::execute (ta=..., d=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/arena.cpp:674

15 0x000000000040ca58 in main::{lambda()#1}::operator()() const ()

16 0x000000000040b62c in main ()

This seems to be related to the TrackerDTC? Not obviously in the code I had modified. I will look and see if I understand what is going on. (This was running before I did the ‘git pull’).

-Anders

Anders Ryd @.**@.>

On Feb 15, 2022, at 5:27 PM, Anders Ryd @.**@.>> wrote:

I have just now pushed the changes for the MC in the emulation to the MP_cleanup_220208 branch. I’m doing some check to make sure this is OK. (I guess you rebased this branch? I picked up a number of other changes when I did a ‘git pull’….)

-Anders

Anders Ryd @.**@.>

On Feb 15, 2022, at 2:01 PM, Brent R. Yates @.**@.>> wrote:

Will the emulation fix to the MC, needed to give agreement with HLS, be submitted as a separate PR?

@arydhttps://github.com/aryd have you pushed the MC updates, or were all those fixes just in the HLS implementation?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-L1TK/cmssw/pull/133#issuecomment-1040669355, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTOTP5Y4DCLU4JCSXBTU3KPHDANCNFSM5OPKST5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

aryd commented 2 years ago

Never mind - I did a ’scram b clean’ at the top and rebuilt all code. Seems to work OK now.

-Anders

Anders Ryd @.**@.>

On Feb 15, 2022, at 5:42 PM, Anders Ryd @.**@.>> wrote:

OK - the latest code does not seem to run.

I’m running:

cmsRun L1TrackNtupleMaker_cfg.py

and it fails with:

Thread 1 (Thread 0x7f12781e4540 (LWP 5822)):

0 0x00007f127a07dddd in poll () from /lib64/libc.so.6

1 0x00007f1273ed67b7 in full_read.constprop () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so

2 0x00007f1273ed70ec in edm::service::InitRootHandlers::stacktraceFromThread() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so

3 0x00007f1273eda59b in sig_dostack_then_abort () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so

4

5 0x00007f1222f43af0 in edm::eventsetup::CallbackProxy<edm::eventsetup::Callback<trackerDTC::ProducerLayerEncoding, std::unique_ptr<trackerDTC::LayerEncoding, std::default_delete >, trackerDTC::LayerEncodingRcd, edm::eventsetup::CallbackSimpleDecorator >, trackerDTC::LayerEncodingRcd, std::unique_ptr<trackerDTC::LayerEncoding, std::default_delete > >::invalidateCache() () from /afs/cern.ch/work/a/aryd/public/12_0_0_pre4_MP_Fixes/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginTrackerDTCPlugins.sohttp://cern.ch/work/a/aryd/public/12_0_0_pre4_MP_Fixes/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginTrackerDTCPlugins.so

6 0x00007f127cbe6aa1 in edm::eventsetup::EventSetupRecordImpl::invalidateProxies() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

7 0x00007f127cbe4930 in edm::FunctorWaitingTask<edm::eventsetup::EventSetupRecordIOVQueue::startNewIOVAsync(edm::WaitingTaskHolder const&, edm::WaitingTaskList&)::{lambda(edm::LimitedTaskQueue::Resumer)#1}::operator()(edm::LimitedTaskQueue::Resumer)::{lambda(std::__exception_ptr::exception_ptr const*)#1}>::execute() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

8 0x00007f127cb6950f in tbb::detail::d1::function_task<edm::WaitingTaskHolder::doneWaiting(std::__exception_ptr::exception_ptr)::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

9 0x00007f127b3afd0b in tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::external_waiter> (this=0x7f1276b5be00, t=0x7f1276a16700, waiter=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.h:396

10 0x00007f127b3ac7e5 in tbb::detail::r1::task_dispatcher::local_wait_for_all (waiter=..., t=0x0, this=0x7f1276b5be00) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.cpp:178

11 tbb::detail::r1::task_dispatcher::execute_and_wait (t=0x0, wait_ctx=..., w_ctx=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.cpp:168

12 0x00007f127cb8fdb6 in edm::EventProcessor::taskCleanup() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so

13 0x000000000040bb2c in tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const ()

14 0x00007f127b394970 in tbb::detail::r1::task_arena_impl::execute (ta=..., d=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/arena.cpp:674

15 0x000000000040ca58 in main::{lambda()#1}::operator()() const ()

16 0x000000000040b62c in main ()

This seems to be related to the TrackerDTC? Not obviously in the code I had modified. I will look and see if I understand what is going on. (This was running before I did the ‘git pull’).

-Anders

Anders Ryd @.**@.>

On Feb 15, 2022, at 5:27 PM, Anders Ryd @.**@.>> wrote:

I have just now pushed the changes for the MC in the emulation to the MP_cleanup_220208 branch. I’m doing some check to make sure this is OK. (I guess you rebased this branch? I picked up a number of other changes when I did a ‘git pull’….)

-Anders

Anders Ryd @.**@.>

On Feb 15, 2022, at 2:01 PM, Brent R. Yates @.**@.>> wrote:

Will the emulation fix to the MC, needed to give agreement with HLS, be submitted as a separate PR?

@arydhttps://github.com/aryd have you pushed the MC updates, or were all those fixes just in the HLS implementation?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-L1TK/cmssw/pull/133#issuecomment-1040669355, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTOTP5Y4DCLU4JCSXBTU3KPHDANCNFSM5OPKST5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

bryates commented 2 years ago

Never mind - I did a ’scram b clean’ at the top and rebuilt all code. Seems to work OK now. -Anders Anders Ryd @.**@.> On Feb 15, 2022, at 5:42 PM, Anders Ryd @.**@.>> wrote: OK - the latest code does not seem to run. I’m running: cmsRun L1TrackNtupleMaker_cfg.py and it fails with: Thread 1 (Thread 0x7f12781e4540 (LWP 5822)): #0 0x00007f127a07dddd in poll () from /lib64/libc.so.6 #1 0x00007f1273ed67b7 in full_read.constprop () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so #2 0x00007f1273ed70ec in edm::service::InitRootHandlers::stacktraceFromThread() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so #3 0x00007f1273eda59b in sig_dostack_then_abort () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginFWCoreServicesPlugins.so #4 #5 0x00007f1222f43af0 in edm::eventsetup::CallbackProxy<edm::eventsetup::Callback<trackerDTC::ProducerLayerEncoding, std::unique_ptr<trackerDTC::LayerEncoding, std::default_delete >, trackerDTC::LayerEncodingRcd, edm::eventsetup::CallbackSimpleDecorator >, trackerDTC::LayerEncodingRcd, std::unique_ptr<trackerDTC::LayerEncoding, std::default_delete > >::invalidateCache() () from /afs/cern.ch/work/a/aryd/public/12_0_0_pre4_MP_Fixes/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginTrackerDTCPlugins.sohttp://cern.ch/work/a/aryd/public/12_0_0_pre4_MP_Fixes/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/pluginTrackerDTCPlugins.so #6 0x00007f127cbe6aa1 in edm::eventsetup::EventSetupRecordImpl::invalidateProxies() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so #7 0x00007f127cbe4930 in edm::FunctorWaitingTask<edm::eventsetup::EventSetupRecordIOVQueue::startNewIOVAsync(edm::WaitingTaskHolder const&, edm::WaitingTaskList&)::{lambda(edm::LimitedTaskQueue::Resumer)#1}::operator()(edm::LimitedTaskQueue::Resumer)::{lambda(std::__exception_ptr::exception_ptr const*)#1}>::execute() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so #8 0x00007f127cb6950f in tbb::detail::d1::function_task<edm::WaitingTaskHolder::doneWaiting(std::__exception_ptr::exception_ptr)::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so #9 0x00007f127b3afd0b in tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::external_waiter> (this=0x7f1276b5be00, t=0x7f1276a16700, waiter=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.h:396 #10 0x00007f127b3ac7e5 in tbb::detail::r1::task_dispatcher::local_wait_for_all (waiter=..., t=0x0, this=0x7f1276b5be00) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.cpp:178 #11 tbb::detail::r1::task_dispatcher::execute_and_wait (t=0x0, wait_ctx=..., w_ctx=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/task_dispatcher.cpp:168 #12 0x00007f127cb8fdb6 in edm::EventProcessor::taskCleanup() () from /cvmfs/cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.sohttp://cms.cern.ch/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_0_pre4/lib/slc7_amd64_gcc900/libFWCoreFramework.so #13 0x000000000040bb2c in tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const () #14 0x00007f127b394970 in tbb::detail::r1::task_arena_impl::execute (ta=..., d=...) at /data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_0_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_0_0_pre4-build/BUILD/slc7_amd64_gcc900/external/tbb/v2021.2.0-llifpc/tbb-v2021.2.0/src/tbb/arena.cpp:674 #15 0x000000000040ca58 in main::{lambda()#1}::operator()() const () #16 0x000000000040b62c in main () This seems to be related to the TrackerDTC? Not obviously in the code I had modified. I will look and see if I understand what is going on. (This was running before I did the ‘git pull’). -Anders Anders Ryd @.**@.> On Feb 15, 2022, at 5:27 PM, Anders Ryd @.**@.>> wrote: I have just now pushed the changes for the MC in the emulation to the MP_cleanup_220208 branch. I’m doing some check to make sure this is OK. (I guess you rebased this branch? I picked up a number of other changes when I did a ‘git pull’….) -Anders Anders Ryd @.**@.> On Feb 15, 2022, at 2:01 PM, Brent R. Yates @.**@.>> wrote: Will the emulation fix to the MC, needed to give agreement with HLS, be submitted as a separate PR? @arydhttps://github.com/aryd have you pushed the MC updates, or were all those fixes just in the HLS implementation? — Reply to this email directly, view it on GitHub<#133 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTOTP5Y4DCLU4JCSXBTU3KPHDANCNFSM5OPKST5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

Good to know, it crashed on my end too, but I thought the file was complete. I'll run a clean compile on my end to make sure it works.

tomalin commented 2 years ago

This fails git CI, because MP_cleanup_220208 did not start from the latest version of L1TK-dev-12_0_0_pre4.

bryates commented 2 years ago

I just did another rebase and force push. I also did a clean compile on my end, and it no longer crashes. I was also able to run L1TrackNtuplePlot.C on my end, producing:

efficiency for |eta| < 1.0 = 95.9133 +- 0.571766
efficiency for 1.0 < |eta| < 1.75 = 93.7282 +- 1.01199
efficiency for 1.75 < |eta| < 2.4 = 94.3182 +- 1.23387
combined efficiency for |eta| < 2.4 = 95.0588 +- 0.470145 = 2020/2125

efficiency for pt > 2 = 95.0588 +- 0.470145
efficiency for 2 < pt < 8.0 = 95.5513 +- 0.523517
efficiency for pt > 8.0 = 93.7282 +- 1.01199
efficiency for pt > 40.0 = 90.6977 +- 4.42955

# TP/event (pt > 2) = 149.54
# TP/event (pt > 3.0) = 49.45
# TP/event (pt > 10.0) = 4.63
# tracks/event (no pt cut)= 177.62
# tracks/event (pt > 2) = 164.02
# tracks/event (pt > 3.0) = 57.62
# tracks/event (pt > 10.0) = 6.13

which agrees with @tomalin's comment from earlier.

aryd commented 2 years ago

Yes. But to expand: The correct number of projections to process is 105. But I changed the code so that the three clocks that are lost due to the merging process in HLS is now explicit in the emulation code. I think that this makes it easier to understand the code.

-Anders

Anders Ryd @.**@.>

On Feb 16, 2022, at 6:07 PM, Ian Tomalin @.**@.>> wrote:

@tomalin commented on this pull request.

In L1Trigger/TrackFindingTracklet/interface/Settings.hhttps://github.com/cms-L1TK/cmssw/pull/133#discussion_r808529687:

@@ -780,7 +780,7 @@ namespace trklet { {"TC", 108}, {"PR", 108}, {"ME", 108},

  • {"MC", 104},

Is the change in the MC truncation from 104 back to 108 intentional?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-L1TK/cmssw/pull/133#pullrequestreview-885249910, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTNYLTXZBED7HPD4DS3U3QU4ZANCNFSM5OPKST5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

tomalin commented 2 years ago

Please add comment at end of line https://github.com/cms-L1TK/cmssw/blob/MP_cleanup_220208/L1Trigger/TrackFindingTracklet/interface/Settings.h#L783 , where MC truncation is set equal to 108, saying something like "But MC emulation subtracts 3 clks from this".

bryates commented 2 years ago

Please add comment at end of line https://github.com/cms-L1TK/cmssw/blob/MP_cleanup_220208/L1Trigger/TrackFindingTracklet/interface/Settings.h#L783 , where MC truncation is set equal to 108, saying something like "But MC emulation subtracts 3 clks from this".

Done. https://github.com/cms-L1TK/cmssw/blob/df1154ee6e7ec9d77dda602a5aed5d94bbd10015/L1Trigger/TrackFindingTracklet/interface/Settings.h#L783-L786