search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Ian tidy up #137

Closed tomalin closed 2 years ago

tomalin commented 2 years ago

Cosmetic changes:

1) Constants used to get DTC name from ATCA slot number moved from L1FPGATrackProducer.cc to Settngs.h. Also put underscore at end of name of L1FPGATrackProducer data member "settings" to match usual CMSSW style. 2) Functions in TrackletConfigBuilder declared "const", if they don't change class data members. (CMSSW style requirement) 3) Added comments to Settings.h to make clear which params have their values overridden by python cfg. 4) Removed duplicate function TCNAme() in TrackletConfigBuilder

tomalin commented 2 years ago

rebased

skinnari commented 2 years ago

looks good, will approve and merge