search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Displaced tracking phi fix #147

Closed ryanm124 closed 2 years ago

ryanm124 commented 2 years ago

D76_DispMu_NoPU_ExactFix_vs_Rounded_eff_phi_sector D76_DispMu_NoPU_ExactFix_vs_Rounded_eff_d0 D76_DispMu_NoPU_ExactFix_BitShift_eff_phi_sector

PR description:

Additional terms to exact (integer) and approximate (floating point) calculations of triplet phi at critical radius for displaced tracks. Exact calculation of phicrit in line 595 of TrackletCalculatorDisplaced would use "2.83 * id0" but this has been rounded to "2" for computational speed. Attached are plots showing efficiency versus local phi coordinate for proposed change versus default calculation as well as efficiency vs local phi and efficiency vs d0 for the rounded phi calculation using "2" and phi calculation using"2.83".

skinnari commented 2 years ago

we confirmed with Yuri to use the simpler 2* version, and will therefore now merge this.