search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Update chi2 tq bins #165

Closed cgsavard closed 2 years ago

cgsavard commented 2 years ago

PR description:

Supersedes PR #163 which needed to be from a cms-L1TK branch.

This PR updates the binning method in the track quality class with the chi2 variables. These variables are now taken directly from the TTTrack word. This also cleans up the TrackQuality class to only use create variables that are used by the default track quality classifier.

PR validation:

I have tested to make sure that the old binning method produced the exact same results as the bins pulled directly from the TTTrack word. Therefore, this does not affect the performance of the classifier at all. I also checked to make sure that the cmssw and python versions of the models output the same values.

tomalin commented 2 years ago

This failed git CI as the obligatory code formatting was not run https://gitlab.cern.ch/cms-l1tk/cmssw_CI/-/pipelines/4053600 .

cgsavard commented 2 years ago

@tomalin Thank you for the heads up, I have done the code formatting and the tests are all successful now.