Closed bryates closed 2 years ago
As I hear no objections, I'm merging this PR.
I think this got merged as I can not fund PR #185 anymore?
-Anders
Anders Ryd @.**@.>
On Oct 31, 2022, at 7:03 AM, Ian Tomalin @.**@.>> wrote:
@tomalin approved this pull request.
Code looks OK to me, but @arydhttps://github.com/aryd should indicate if he also happy to approve it.
— Reply to this email directly, view it on GitHubhttps://github.com/cms-L1TK/cmssw/pull/185#pullrequestreview-1161693583, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTKQV6GL3NT7DVF4LPDWF6RRFANCNFSM6AAAAAAQKTERB4. You are receiving this because you were mentioned.Message ID: @.***>
PR description:
These changes implements a LUT as function of the radial projection in the disks to determine which r bins needs to be searched - and the finer position within the r bin. It produces an 8-bit word (
ffffrrrd
) wheref
isfine r
,r
isrbin1
, andd
is difference (rbin1 != rbin2
)It also includes an additional pipeline step to match the HLS implementation.
PR validation:
Designed for HLS [WIP] PR #242