kf bug fixes, f/w sync.

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.

http://cms-sw.github.io/

Apache License 2.0

4 stars 5 forks source link

kf bug fixes, f/w sync. #188

Closed tschuh closed 1 year ago

tschuh commented 1 year ago

Updated demonstrator sw to take newest emp formats into account. Two bugs fixed:

sw did not add stubs up to kfMaxStubs, it used kfMinStubs instead
sw did not skip last populated layer

tomalin commented 1 year ago

We don't keep copies of the wiring .dat files in TrackFindingTracklet/data/, except for *hourglassExtended.dat, (because TrackletConfigBuilder.cc can't yet calculate the wiring map for displaced tracking). The reason for this is that these files are temporary, and change periodically, so keeping a copy risks causing mistakes. And we wouldn't be allowed to commit them to central CMSSW.

tomalin commented 1 year ago

This PR looks good to me, aside from my TrackFindingTracklet/data/ comment above.

tschuh commented 1 year ago

I did put the reduced ones now only in so that chris can catch them, as soon as he has them we can remove them again.

tschuh commented 1 year ago

the reduced dat files are now removed again

tschuh commented 1 year ago

sorry for my late reply. One could always give a relative path to the project folder wrt to the patch from where one executes cmsRun. But that is not so useful since it is not obvious that everyone has the same path and especially same project name. In your example one would need to have the ipbb project (where parts are a git repo) in your cmssw area which is a git repo. One would need to be careful no not commit that. When you have a good solution I would happily use that, I was not able to find one.