Warning: this changes the indentation of all the Tracklet .cc files, explaining why so many lines of code change. But there is little ongoing work at the moment, so this shouldn't give clashes. It is also the first PR here that has not gone into central CMSSW yet, so it may be possible to push it by itself to central CMSSW after merge.
This cleanup is helpful in the future emulation code, since all namespaces are treated the same way.
The PR also includes some small cleanups of the BuildFile.xml's.
The TMTT & TrackerTFP .cc files wrap the class implementations in a namespace. e.g. https://github.com/cms-L1TK/cmssw/blob/L1TK-dev-12_6_0_pre5/L1Trigger/TrackFindingTMTT/src/InputData.cc#L23 , whereas the Tracklet ones do not, instead just using "using namespace" https://github.com/cms-L1TK/cmssw/blob/L1TK-dev-12_6_0_pre5/L1Trigger/TrackFindingTracklet/src/MatchEngine.cc#L16 . The Tracklet method is not recommended -- see https://google.github.io/styleguide/cppguide.html#Namespaces and https://stackoverflow.com/questions/8681714/correct-way-to-define-c-namespace-methods-in-cpp-file , and is not used elsewhere in CMSSW. e.g. https://cmssdt.cern.ch/lxr/source/FWCore/Common/src/TriggerNames.cc . This PR therefore corrects it.
Warning: this changes the indentation of all the Tracklet .cc files, explaining why so many lines of code change. But there is little ongoing work at the moment, so this shouldn't give clashes. It is also the first PR here that has not gone into central CMSSW yet, so it may be possible to push it by itself to central CMSSW after merge.
This cleanup is helpful in the future emulation code, since all namespaces are treated the same way.
The PR also includes some small cleanups of the BuildFile.xml's.