cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

MP fix disk deltar #200

Closed bryates closed 1 year ago

bryates commented 1 year ago

PR description:

This PR fixes agreement in the disks between the emulation and the HLS implementation. The calculation for the ideltar value is updated (shifting by one to account for the different number of bits in the stubs and projections). The best_ideltaz_barrel calculation is also updated.

This PR will bring the emulation in agreement with the HLS PR https://github.com/cms-L1TK/firmware-hls/pull/242 (still a work in progress).

Temporary test vectors: https://cernbox.cern.ch/remote.php/dav/public-files/KMwIFrlRqnQTtGc/MemPrints_byates_100_1260.tar.gz

PR validation:

The HLS implementation of the MP disks is still a work in progress, but so far D1 has full agreement for 99/100 events (event 96 has 9 missing FMs in the HLS, likely due to truncation)