Closed dally96 closed 1 year ago
The number one thing I'd like to see before approving this PR is a plot of efficiency vs. phi before and after the change, with enough detail to see small dips around bin edges if they exist.
The number one thing I'd like to see before approving this PR is a plot of efficiency vs. phi before and after the change, with enough detail to see small dips around bin edges if they exist.
Like this? effVsPhi_D76_Sector_Cut.pdf
Variable outputTracks_ in class PurgeDuplicate is not a class data member, so should not end in an underscore.
"std::vector invented_coords" in PurgeDuplicate.cc is weird. Please specify the variable type (e.g. std::vector
With this PR, phi bins would be added to duplicate removal to increase performance.
With this PR, the duplicate fraction is reduced to 0.466% and has efficiencies
Before this PR, the duplicate fraction was 0.741%, and the efficiencies were