cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Clean up TrackQuality onyx file (when L1TK-dev-12_6_0_pre5 merged) #222

Closed tomalin closed 6 months ago

tomalin commented 1 year ago

1) After cms-L1TK:L1TK-dev-12_6_0_pre5, which includes the Track Quality emulation code, is merged into central CMSSW, a PR should be made to https://github.com/cms-data/L1Trigger-TrackTrigger . This should remove the old .onnx data file, which is then no longer needed because both Track Quality emulation & Track Quality simulation will then use the same .json file.

2) All BDT applications in CMSSW should use a single conifer.h file. We should therefore switch to using the particle flow one https://github.com/cms-sw/cmssw/blob/3cd98a0b792252bb046157709fc9a3029f148cc2/L1Trigger/Phase2L1ParticleFlow/interface/conifer.h . However, as the latter is introduced in CMSSW_13_2_X , we must wait until cms-L1TK is rebased off that branch (or later) before making this change.

https://github.com/cms-sw/cmssw/L1Trigger/Phase2L1ParticleFlow/interface/conifer.h

tomalin commented 6 months ago

done