cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Fix TQ input variables #227

Closed cgsavard closed 1 year ago

cgsavard commented 1 year ago

Copy of closed PR #226.

PR description:

The input variables for the latest track quality classifier (emulated version, runs with newKF emulation) changed. However, the variables set for the simulation version of the code did not get updated to reflect this change in the classifier. This PR updates the variables to the proper ones.

The changes in the variables are a consequence of the emulation. In emulation tanl is more readily available than eta and z0 is scaled by a non-base 2 value which makes it more costly to change back. Therefore, the bdt uses tanl and a scaled version of the z0 that are both easier to obtain.

PR validation:

I checked that the outputs from the MVA variable calculated by the cmssw code matched the output from the python version of the classifier that was used for the training of the bdt. The results here show perfect matching between the cmssw and python version of the classifier: Screen Shot 2023-07-10 at 4 33 24 PM

cgsavard commented 1 year ago

Commenting since there has been no activity in a bit @tomalin @skinnari

skinnari commented 1 year ago

this seems good to me, I think we can merge it.