search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Comments concerning the rinv bins #239

Closed dally96 closed 11 months ago

dally96 commented 11 months ago

This pull requests adds some more comments explaining why the rinv bin edges in L1Trigger/TrackFindingTracklet/interface/Settings.h were chosen as such. See here https://github.com/cms-sw/cmssw/pull/42663#discussion_r1344066992.

tomalin commented 11 months ago

Changing 917 files in response to one small git review comment seems excessive! :-)

dally96 commented 11 months ago

Changing 917 files in response to one small git review comment seems excessive! :-)

I think I cloned the development branch and not the PR branch 😅. I'll go ahead and fix that.