search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

StubKiller Class logic broken #241

Closed Chriisbrown closed 1 year ago

Chriisbrown commented 1 year ago

Lines

https://github.com/cms-L1TK/cmssw/blob/d52b66ba054cf42cd816a2961ae5159cb5db82b0/L1Trigger/TrackFindingTracklet/src/StubKiller.cc#L223

https://github.com/cms-L1TK/cmssw/blob/d52b66ba054cf42cd816a2961ae5159cb5db82b0/L1Trigger/TrackFindingTracklet/src/StubKiller.cc#L280

In the stubkiller class are currently checking if the list of layers/modukes to be killed is empty before killing the stubs so no stubs get killed, this was changed from if ( layersToKill.size() > 0 ) here: https://github.com/EmyrClement/StubKiller/blob/214e7b674ea94ada595abcc66a9296c49044acde/StubKiller.cc#L230 which checks if the list of layers/modules to be killed is not empty, I'm unsure why this was changed as it stops the stub killer from working

emily-tsai11 commented 1 year ago

Hi Chris, thanks for pointing this out. I will make a PR later today with a fix.

emily-tsai11 commented 1 year ago

PR submitted here: https://github.com/cms-L1TK/cmssw/pull/244

Chriisbrown commented 1 year ago

Can close this issue as it has been addressed in #244