cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

MP fix keep/cut logic order #246

Closed bryates closed 1 year ago

bryates commented 1 year ago

PR description:

This PR fixes a bug in the MP logic. When DoMultipleMatches is set to False, the MC section decides whether additional matches to the same projection are worth keeping. The logic for updating the best cut values came before this decision, so worse full matches could sometimes replace a cut value if that particular value was better.

PR validation:

This PR gives full agreement with HLS from L1PHIA to L6PHID (debugging the rest now)