This PR fixes a bug in TrackletProcessorDisplaced.cc that caused efficiency to be extremely low. The bug was introduced when the CMS build crew fixed CLANG warnings, but in doing so removed displaced seeding.
This PR restores the deleted code and fixes the CLANG warnings which were caused by unused variables by outputting some counters to a file if settings_.writeMonitorData("TPD") is true. The counters can be useful for debugging.
PR description:
This PR fixes a bug in TrackletProcessorDisplaced.cc that caused efficiency to be extremely low. The bug was introduced when the CMS build crew fixed CLANG warnings, but in doing so removed displaced seeding.
The changes that introduced the bug are seen here: https://github.com/cms-L1TK/cmssw/commit/818beb0788d5303218ba3430b5a595c3b30e40c7#diff-3becd5e0ce57b58a0103b161658ca69686e19efc936c48255292aa3c1ebd388e
This PR restores the deleted code and fixes the CLANG warnings which were caused by unused variables by outputting some counters to a file if settings_.writeMonitorData("TPD") is true. The counters can be useful for debugging.
Information on the restored efficiency can be found here: Displaced Combined Bug Fix.pdf
After the fix, the efficiency for combined modules is restored fully back to that of uncombined modules for displaced tracking.
PR validation:
scram b -j code-format was used to make some format fixes.