search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Fully Implementing ProjectionCalculator #282

Closed mlarson02 closed 4 weeks ago

mlarson02 commented 3 months ago

This PR completes the implementation of the ProjectionCalculator by taking code from the TrackletCalculatorBase.cc and firmware-hls ProjectionCalculator.h to calculate TrackletProjections from TrackletParameter input. Also makes the required changes in the Tracklet class and TrackletConfigBuilder to remove functionality in TrackletProcessor to calculate projections (now is only calculating parameters).

Some code to calculate projections has been left in the TrackletCalculatorBase.cc to allow the TrackletCalculatorDisplaced.cc to continue working.

tomalin commented 1 month ago

@aryd As Mark Larson has now stopped working on this (but is still contactable), could you please add a comment here explaining what prevents this being merged?

aryd commented 1 month ago

Ian,

I think this should also be ready to merge. There is a little bit of an issue with a slight reduction in the tracking efficiency that Mark did not understand. I have not had a chance to look at this. But I think we should merge this and then sort out the inefficiency before this gets used in an official release.

-Anders

Anders Ryd @.**@.>

On Jul 30, 2024, at 6:28 PM, Ian Tomalin @.**@.>> wrote:

@arydhttps://github.com/aryd As Mark Larson has now stopped working on this (but is still contactable), could you please add a comment here explaining what prevents this being merged?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-L1TK/cmssw/pull/282#issuecomment-2258747028, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTPHOFJVBYPGVEHLLLDZO65L7AVCNFSM6AAAAABJ2LECOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYG42DOMBSHA. You are receiving this because you were mentioned.Message ID: @.***>

tomalin commented 1 month ago

By the way, this fails git CI because the git CI assumes that the PR is being made to cms-L1TK:L1TK-dev-14_0_0_pre2, so rebases the branch to this branch.