cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Add truncation in TrackletProcessorDisplaced #293

Closed cgsavard closed 1 month ago

cgsavard commented 2 months ago

PR description:

Truncation has never been added to the TrackletProcessorDisplaced module and so these changes implement truncation there using the maxstep_['TP'] value in Settings.h here (as the other displaced modules do). Truncation in extended tracking is turned off by default and so this doesn't change the performance of anything, but allows us to properly study truncation for the full extended chain.

PR validation:

After running a couple of checks, the behavior of these changes is exactly as expected. With truncation off, nothing changes. With truncation on, TrackletProcessorDisplaced is capping its processing of objects to the value set in Settings.h.

aehart commented 1 month ago

@cgsavard The only thing I would suggest is adding a separate "TPD" key to the maxstep_ map here: https://github.com/cms-L1TK/cmssw/blob/87c8b0527f45a592d5e2450fa601def9dc5fd7a2/L1Trigger/TrackFindingTracklet/interface/Settings.h#L883-L901

And then use that instead of "TP" in the code you've added. I can see it being useful being able to turn truncation on and off for the prompt and displaced modules separately.

cgsavard commented 1 month ago

The only thing I would suggest is adding a separate "TPD" key to the maxstep_ map

Done!

aehart commented 1 month ago

The only thing I would suggest is adding a separate "TPD" key to the maxstep_ map

Done!

Thanks, @cgsavard! But you should also change "TP" to "TPD" in TrackletProcessorDisplaced.cc, in order to use the new key in maxstep_, and I think you accidentally changed the default algorithm in L1TrackNtupleMaker_cfg.py to HYBRID_DISPLACED. That's probably why the CI is now failing.

cgsavard commented 1 month ago

@aehart Ah yes, I accidentally added the wrong file to the commit. I just fixed the commit so hopefully everything is good now!