search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Clean up TrackletProcessorDisplaced #294

Closed cgsavard closed 3 weeks ago

cgsavard commented 3 weeks ago

PR description:

This work cleans up TrackletProcessorDisplaced in anticipation of the re-structuring required make it follow the TrackletProcessor structure. Clean ups include removing code that is never used, removing repetitive code, removing magic numbers, and using functions that have been developed for TrackletProcessor and have not been updated here. This new version of code should be much easier to work with.

Additionally, one bug was found and fixed. The bug was preventing a lot of D1D2L2 seeds in the negative disk region from being produced (bug here). The fix increases the tracking efficiency in the negative eta region for displaced tracking particles (|d0|>1 cm) while keeping the efficiency the same everywhere else. Following plot shows perfect matching between the clean up and original version of the code, in addition to the increase in efficiency for low eta with the bug fix:

image

PR validation:

I verified that all of the seeds produced before and after these changes are exactly the same, with the exception of more D1D2L2 seeds being produced in the negative disk region due to the bug fix.

aehart commented 3 weeks ago

Aside from the two nit-picky comments above, I think this PR is good to go and a significant improvement in terms of code quality.

cgsavard commented 3 weeks ago

@aehart Thanks for the review! The suggested changes have been made