search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Improve code that writes txt files for HLS #57

Closed tomalin closed 3 years ago

tomalin commented 3 years ago

PR description:

Improve the option to write .txt files needed by HLS, which is enabled by settings writeMem & writeTable.

1) Code now throws exception if it is unable to create the requested .txt files. 2) Code now automatically generates the directories that the .txt files will be written to, if they don't already exist. 3) New settings parameter added: memPath_ = "../data/MemPrints/", to specify the parent directory where the memory data is to be written.

PR validation:

Checked that output txt files are identical to those produced by the original code.

tomalin commented 3 years ago

Logically all these changes look good, they are similar changes across many files. Please run the code formatting commands https://twiki.cern.ch/twiki/bin/view/CMS/L1TrackCodeRules In particular, a lot of your changes have if (condition) (command) where CMSSW wants (for some reason) if (condition) (command)

DONE

djcranshaw commented 3 years ago

Looks good, works as expected.