TrackQuality Code Review

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.

http://cms-sw.github.io/

Apache License 2.0

4 stars 5 forks source link

TrackQuality Code Review #65

Closed Chriisbrown closed 3 years ago

Chriisbrown commented 3 years ago

PR description:

Code fixes for the Track Quality code review:

Inclusion of link to new cms-data repo for default GBDT
Change to track by track string comparison to enum class comparison
Removal of various temporaries
Formatting and style issues

PR validation:

Code checks and formatting tests have been completed

tomalin commented 3 years ago

If I run this code, using default cfg (TrackQuality=False) and without downloading GBDT_default.onnx from git, then the code crashes with error: "RuntimeError: An exception of category 'FileInPathError' occurred. Exception Message: edm::FileInPath unable to find file L1Trigger/TrackTrigger/data/GBDT_default.onnx anywhere in the search path." The original code doesn't do this.

tomalin commented 3 years ago

We've discovered that FileInPath searches $CMSSW_SEARCH_PATH, which includes CMSSW_11_3_0_pre1/external/slc7_amd64_gcc900/data/ . The L1Trigger/TrackTrigger/data/ does not yet appear here, which is why it crashes, but it should do in next prerelease. In mean time, even if track quality is disabled, we'll all have to do: git clone https://github.com/cms-data/L1Trigger-TrackTrigger.git L1Trigger/TrackTrigger/data .