search

cms-L1TK / cmssw

Fork of CMSSW where improvements to L1 tracking code are developed.
http://cms-sw.github.io/
Apache License 2.0
4 stars 5 forks source link

Include commit from fw_synch_210611 #86

Closed skinnari closed 3 years ago

skinnari commented 3 years ago

PR description:

This PR includes one commit from Anders that was included in the fw_synch_210611 tagged version that is used for the HLS version, which had not been propagated to this development branch. In addition it applies code-formats/code-checks to those changes.

skinnari commented 3 years ago

@aryd can you please check that this looks right? it is the commit we discussed on thursday that wasn't propagated yet to the development branch. thanks!

tomalin commented 3 years ago

I've checked this PR doesn't change the tracking performance.

It does change the LUT/ tables, adding a new file VMTableOuterL6.tab, in place of the old file VMTableOuterL5.tab.

This change is consistent with https://github.com/cms-L1TK/firmware-hls/blob/master/TrackletAlgorithm/VMRouter_parameters.h#L186 , which looks for VMTableOuterL6.tab

It does change the MemPrints/ test data, removing files such as:

TrackletProjections_TPROJ_L1D1A_D2PHIB_04.dat

and changing files such as:

VMStubs_VMSME_L4PHIA7n1_04.dat

@trholmes @aehart & @meisonlikesicecream should be aware of this PR.