search

cms-L1TK / project_generation_scripts

Python scripts to generate the wiring map of the tracklet pattern recognition & the top-level HDL that calls the HLS modules in the Hybrid Chain.
1 stars 2 forks source link

Array arguments #13

Closed meisonlikesicecream closed 3 years ago

meisonlikesicecream commented 3 years ago

Updates to allow arrays as HLS module function arguments (and some bitwidth updates). The "indices" of the ports created goes from 0 to n, except for the fullmatch where the index depends on the seed, in accordance with: https://github.com/cms-L1TK/firmware-hls/blob/master/TrackletAlgorithm/MatchCalculator.h#L814-L863

meisonlikesicecream commented 3 years ago

I'm don't think the order of the PRs should matter, but Ian was the one who tried merging our branches (in meiiantest), so he might have a better answer.

EDIT: I might have lied, the changing from "(7 downto 0)" to "(6 downto 0)" was done after our test-merging, so the reason I didn't change L117 and L212 was because they didn't exist in Ians branch.

tomalin commented 3 years ago

I'm don't think the order of the PRs should matter, but Ian was the one who tried merging our branches (in meiiantest), so he might have a better answer.

EDIT: I might have lied, the changing from "(7 downto 0)" to "(6 downto 0)" was done after our test-merging, so the reason I didn't change L117 and L212 was because they didn't exist in Ians branch.

IAN: when testing, we merged Mei-Li's branch into mine. So it's probably safest to merge mine into master first.