Closed meisonlikesicecream closed 3 years ago
I'm don't think the order of the PRs should matter, but Ian was the one who tried merging our branches (in meiiantest), so he might have a better answer.
EDIT: I might have lied, the changing from "(7 downto 0)" to "(6 downto 0)" was done after our test-merging, so the reason I didn't change L117 and L212 was because they didn't exist in Ians branch.
I'm don't think the order of the PRs should matter, but Ian was the one who tried merging our branches (in meiiantest), so he might have a better answer.
EDIT: I might have lied, the changing from "(7 downto 0)" to "(6 downto 0)" was done after our test-merging, so the reason I didn't change L117 and L212 was because they didn't exist in Ians branch.
IAN: when testing, we merged Mei-Li's branch into mine. So it's probably safest to merge mine into master first.
Updates to allow arrays as HLS module function arguments (and some bitwidth updates). The "indices" of the ports created goes from 0 to n, except for the fullmatch where the index depends on the seed, in accordance with: https://github.com/cms-L1TK/firmware-hls/blob/master/TrackletAlgorithm/MatchCalculator.h#L814-L863