cms-L1TK / project_generation_scripts

Python scripts to generate the wiring map of the tracklet pattern recognition & the top-level HDL that calls the HLS modules in the Hybrid Chain.
1 stars 2 forks source link

option to disable root (reduce dependencies) #31

Closed pwittich closed 3 years ago

pwittich commented 3 years ago

This will make moving to python3 easier and reduce dependencies for this tool.

Only touches generator_hdl.py right now.

tomalin commented 3 years ago

https://root.cern/manual/python/ suggests that pyroot is compatible with python3.

pwittich commented 3 years ago

It is, and I don't intend to remove it, but many installations don't have it (e.g anaconda) so having it under a switch makes it a bit easier to run and generate all needed files except the plot. I can switch the default, if you prefer, so that there is no change to the default behavior. This way I can run this e.g. on my laptop.

pwittich commented 3 years ago

frankly I was going to look at making the diagram with matplotlib too ... It looks pretty straightforward.

tomalin commented 3 years ago

I don't mind if -graph defaults to on or off. Please document new option in READMD.md below "Optional arguments include:".