cms-L1TK / project_generation_scripts

Python scripts to generate the wiring map of the tracklet pattern recognition & the top-level HDL that calls the HLS modules in the Hybrid Chain.
1 stars 2 forks source link

Add support for Python3 #32

Closed pwittich closed 3 years ago

pwittich commented 3 years ago

Add support for python3, while maintaining support for python 2. This code requires python3 > 3.6.

The biggest changes are

I compared the output of the following command between python 2 on the master branch and python 2 and 3 on this branch and diff'd the files. No difference.

./generator_hdl.py ~/src/firmware-hls --uut TC_L1L2E -u 1 -d 0  --no-graph

This is probably not exhaustive; anyone have other tests I should run?

I didn't check the root stuff in python 2 or 3 since I don't have that on this machine.

I also added a github action to test if newly added code is compatible with python3 or not, to ensure we don't have any regression.

pwittich commented 3 years ago

I also tested

./makeReducedConfig.py --no-graph

on master with py2 and on this branch with py2 and py3. No difference for the reduced_* files.