search

cms-L1TK / project_generation_scripts

Python scripts to generate the wiring map of the tracklet pattern recognition & the top-level HDL that calls the HLS modules in the Hybrid Chain.
1 stars 2 forks source link

Fix C++ parsing & update README #5

Closed tomalin closed 3 years ago

tomalin commented 3 years ago

Minor updates to README file

Minor fixes to python scripts for VHDL creation:

1) Splitting arguments of HLS function by comma failed if the argument type was templated, with commas separating the template arguments. This is now fixed (providing the argument type doesn't have nested template brackets).

2) Fixed warning message about "unnecessary EOF" in call to os.system()

3) Adjusted default text/box sizes of script making TrackletProject.pdf to make this look good for PRMEMC chain. (They were far too small).

pwittich commented 3 years ago

I'd still like a response to my comment. Also suggest better names for branches in the future.

tomalin commented 3 years ago

I'd still like a response to my comment. Also suggest better names for branches in the future.

@pwittich Name of PR changed to more meaningful "Fix C++ parsing & update README". I don't see any other comment here from you?

pwittich commented 3 years ago

it is on this page (scroll up) or do you not see it?

tomalin commented 3 years ago

@pwittich I really can't see your earlier comment about this PR. I'd be grateful if you could post it again.

skinnari commented 3 years ago

(FWIW neither can I)